From 4063fef03965a72e0d2e9f121c50cc8c14bd1d9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dag-Erling=20Sm=C3=B8rgrav?= Date: Tue, 3 Apr 2012 20:13:38 +0000 Subject: [PATCH] Start writing unit tests for openpam_readlinev(). One of them fails, but I can't quite decide whether the code or the test is incorrect. git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@562 185d5e19-27fe-0310-9dcf-9bff6b9f3609 --- t/Makefile.am | 2 +- t/t_openpam_readlinev.c | 280 ++++++++++++++++++++++++++++++++++++++++ t/t_openpam_readword.c | 12 ++ 3 files changed, 293 insertions(+), 1 deletion(-) create mode 100644 t/t_openpam_readlinev.c diff --git a/t/Makefile.am b/t/Makefile.am index 75eff1d..75efae8 100644 --- a/t/Makefile.am +++ b/t/Makefile.am @@ -3,7 +3,7 @@ INCLUDES = -I$(top_srcdir)/include -I$(top_srcdir)/lib # tests -TESTS = t_openpam_readword +TESTS = t_openpam_readword t_openpam_readlinev check_PROGRAMS = $(TESTS) # libt - common support code diff --git a/t/t_openpam_readlinev.c b/t/t_openpam_readlinev.c new file mode 100644 index 0000000..ffc0a18 --- /dev/null +++ b/t/t_openpam_readlinev.c @@ -0,0 +1,280 @@ +/*- + * Copyright (c) 2012 Dag-Erling Smørgrav + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer + * in this position and unchanged. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * $Id$ + */ + +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +#include "openpam_impl.h" +#include "t.h" + +static char filename[1024]; +static FILE *f; + +/* + * Open the temp file and immediately unlink it so it doesn't leak in case + * of premature exit. + */ +static void +orlv_open(void) +{ + int fd; + + if ((fd = open(filename, O_RDWR|O_CREAT|O_TRUNC, 0600)) < 0) + err(1, "%s(): %s", __func__, filename); + if ((f = fdopen(fd, "r+")) == NULL) + err(1, "%s(): %s", __func__, filename); + if (unlink(filename) < 0) + err(1, "%s(): %s", __func__, filename); +} + +/* + * Write text to the temp file. + */ +static void +orlv_output(const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + vfprintf(f, fmt, ap); + va_end(ap); + if (ferror(f)) + err(1, "%s", filename); +} + +/* + * Rewind the temp file. + */ +static void +orlv_rewind(void) +{ + + errno = 0; + rewind(f); + if (errno != 0) + err(1, "%s(): %s", __func__, filename); +} + +/* + * Read a line from the temp file and verify that the result matches our + * expectations: whether a line was read at all, how many and which words + * it contained, how many lines were read (in case of quoted or escaped + * newlines) and whether we reached the end of the file. + */ +static int +orlv_expect(const char **expectedv, int lines, int eof) +{ + int expectedc, gotc, i, lineno = 0; + char **gotv; + + expectedc = 0; + if (expectedv != NULL) + while (expectedv[expectedc] != NULL) + ++expectedc; + gotv = openpam_readlinev(f, &lineno, &gotc); + if (ferror(f)) + err(1, "%s(): %s", __func__, filename); + if (expectedv != NULL && gotv == NULL) { + t_verbose("expected %d words, got nothing\n", expectedc); + return (0); + } + if (expectedv == NULL && gotv != NULL) { + t_verbose("expected nothing, got %d words\n", gotc); + FREEV(gotc, gotv); + return (0); + } + if (expectedv != NULL && gotv != NULL) { + if (expectedc != gotc) { + t_verbose("expected %d words, got %d\n", + expectedc, gotc); + FREEV(gotc, gotv); + return (0); + } + for (i = 0; i < gotc; ++i) { + if (strcmp(expectedv[i], gotv[i]) != 0) { + t_verbose("word %d: expected <<%s>>, " + "got <<%s>>\n", i, expectedv[i], gotv[i]); + FREEV(gotc, gotv); + return (0); + } + } + FREEV(gotc, gotv); + } + if (lineno != lines) { + t_verbose("expected to advance %d lines, advanced %d lines\n", + lines, lineno); + return (0); + } + if (eof && !feof(f)) { + t_verbose("expected EOF, but didn't get it\n"); + return (0); + } + if (!eof && feof(f)) { + t_verbose("didn't expect EOF, but got it anyway\n"); + return (0); + } + return (1); +} + +/* + * Close the temp file. + */ +void +orlv_close(void) +{ + + if (fclose(f) != 0) + err(1, "%s(): %s", __func__, filename); + f = NULL; +} + + +/*************************************************************************** + * Lines without words + */ + +T_FUNC(empty_input, "empty input") +{ + int ret; + + orlv_open(); + ret = orlv_expect(NULL, 0 /*lines*/, 1 /*eof*/); + orlv_close(); + return (ret); +} + +T_FUNC(empty_line, "empty line") +{ + int ret; + + orlv_open(); + orlv_output("\n"); + orlv_rewind(); + ret = orlv_expect((const char *[]){ NULL }, + 1 /*lines*/, 0 /*eof*/); + orlv_close(); + return (ret); +} + +T_FUNC(unterminated_line, "unterminated line") +{ + int ret; + + orlv_open(); + orlv_output(" "); + orlv_rewind(); + ret = orlv_expect((const char *[]){ NULL }, + 0 /*lines*/, 1 /*eof*/); + orlv_close(); + return (ret); +} + +T_FUNC(whitespace, "whitespace") +{ + int ret; + + orlv_open(); + orlv_output(" \n"); + orlv_rewind(); + ret = orlv_expect((const char *[]){ NULL }, + 1 /*lines*/, 0 /*eof*/); + orlv_close(); + return (ret); +} + +T_FUNC(comment, "comment") +{ + int ret; + + orlv_open(); + orlv_output("# comment\n"); + orlv_rewind(); + ret = orlv_expect((const char *[]){ NULL }, + 1 /*lines*/, 0 /*eof*/); + orlv_close(); + return (ret); +} + +T_FUNC(whitespace_before_comment, "whitespace before comment") +{ + int ret; + + orlv_open(); + orlv_output(" # comment\n"); + orlv_rewind(); + ret = orlv_expect((const char *[]){ NULL }, + 1 /*lines*/, 0 /*eof*/); + orlv_close(); + return (ret); +} + + +/*************************************************************************** + * Boilerplate + */ + +const struct t_test *t_plan[] = { + T(empty_input), + T(empty_line), + T(unterminated_line), + T(whitespace), + T(comment), + T(whitespace_before_comment), + + NULL +}; + +const struct t_test ** +t_prepare(int argc, char *argv[]) +{ + + (void)argc; + (void)argv; + snprintf(filename, sizeof filename, "%s.%d.tmp", t_progname, getpid()); + if (filename == NULL) + err(1, "asprintf()"); + return (t_plan); +} + +void +t_cleanup(void) +{ +} diff --git a/t/t_openpam_readword.c b/t/t_openpam_readword.c index 8c0c1c4..bd235b4 100644 --- a/t/t_openpam_readword.c +++ b/t/t_openpam_readword.c @@ -188,6 +188,18 @@ T_FUNC(empty_line, "empty line") return (ret); } +T_FUNC(unterminated_line, "unterminated line") +{ + int ret; + + orw_open(); + orw_output(" "); + orw_rewind(); + ret = orw_expect(NULL, 0 /*lines*/, 1 /*eof*/, 0 /*eol*/); + orw_close(); + return (ret); +} + T_FUNC(single_whitespace, "single whitespace") { int ret;