From 4e92aa7e241dae81357765de31443f7304deb10c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dag-Erling=20Sm=C3=B8rgrav?= Date: Sat, 9 Jan 2016 17:26:18 +0000 Subject: [PATCH] Plug potential memory leak reported by Coverity Scan. I'm not sure it can actually ever occur, but the extra free() is harmless, provided we make sure not to free() something we're still using. git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@877 185d5e19-27fe-0310-9dcf-9bff6b9f3609 --- lib/libpam/openpam_readlinev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libpam/openpam_readlinev.c b/lib/libpam/openpam_readlinev.c index a818dec..7d62faf 100644 --- a/lib/libpam/openpam_readlinev.c +++ b/lib/libpam/openpam_readlinev.c @@ -79,6 +79,7 @@ openpam_readlinev(FILE *f, int *lineno, int *lenp) /* insert our word */ wordv[wordvlen++] = word; wordv[wordvlen] = NULL; + word = NULL; } if (errno != 0) { /* I/O error or out of memory */ @@ -86,6 +87,7 @@ openpam_readlinev(FILE *f, int *lineno, int *lenp) while (wordvlen--) free(wordv[wordvlen]); free(wordv); + free(word); errno = serrno; return (NULL); }