Commit Graph

159 Commits

Author SHA1 Message Date
Dag-Erling Smørgrav a6ea311d45 Make sure OPENPAM_MODULES_DIR has a trailing slash.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@311 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-06-10 18:51:37 +00:00
Dag-Erling Smørgrav 9787583d8d If the module path is relative, prepend the module installation
directory which was specified at configure time.

Inspired by:	NetBSD


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@308 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-06-09 21:32:00 +00:00
Dag-Erling Smørgrav 554a37183c Better to use unsigned char when isspace() is involved.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@304 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-02-03 08:22:02 +00:00
Dag-Erling Smørgrav 3b5c3d5aab Leave alarm() alone if openpam_ttyconv_timeout is zero or negative.
Also bobbit an unused variable.

Obtained from:	NetBSD


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@301 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-02-01 12:00:02 +00:00
Dag-Erling Smørgrav b8dd03287c Additional healthy paranoia.
Obtained from:	NetBSD


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@300 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-02-01 11:57:49 +00:00
Dag-Erling Smørgrav cc2b3e94a9 Whitespace nits.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@294 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-01-31 15:32:02 +00:00
Dag-Erling Smørgrav 322e461278 Formatting and documentation nits.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@291 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-01-28 15:24:44 +00:00
Dag-Erling Smørgrav 5b853cf298 Use FREE() instead of free().
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@290 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-01-28 15:21:35 +00:00
Dag-Erling Smørgrav 9d0dd0c39b Add openpam_free_envlist(). I'm tired of freeing them by hand.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@289 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-01-28 14:47:41 +00:00
Dag-Erling Smørgrav 7adc56bb5f Hard sentence breaks in inline documentation.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@288 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-01-28 14:08:44 +00:00
Dag-Erling Smørgrav 61e4fb1d75 Add explicit section numbers to sete[gu]id() / setgroups() cross-
references; otherwise, gendoc.pl incorrectly assumes they're in
section 3.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@284 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-01-28 13:57:45 +00:00
Dag-Erling Smørgrav 2486034511 Remove an unnecessary cast, obviating the need for <stdint.h> which
apparently isn't present on some platforms (e.g. Solaris 8)


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@281 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2004-07-27 12:07:13 +00:00
Dag-Erling Smørgrav 58b2c9d06a s/accound/account/
Spotted by:	rwatson


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@280 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2004-03-07 05:04:36 +00:00
Dag-Erling Smørgrav 38daa8ac23 Make the ENTER*() and RETURN*() macros safe from side-effects, and
solve the "dereferencing NULL pointer" warning.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@279 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2004-02-17 11:13:13 +00:00
Dag-Erling Smørgrav e38d7ba072 I originally thought the XSSO was wrong to declare pam_get_data()'s
final argument as void ** rather than const void **, but having seen
the strict aliasing warnings gcc generates at higher -O levels, it
makes a lot more sense.  Change the prototype and definition back to
what the XSSO specifies, and make the necessary changes to avoid
warnings in code that calls pam_get_data().


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@277 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-12-11 17:41:17 +00:00
Dag-Erling Smørgrav 4e4cdb38d4 I completely bungled the previous commit. Don't know what I was
thinking (or smoking) at the time.  Really fix it this time.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@275 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-12-10 17:42:25 +00:00
Dag-Erling Smørgrav 924113f0c6 Belatedly fix confusion about the layout of resp, cf. similar changes
in OpenSSH-portable.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@274 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-11-19 09:36:36 +00:00
Dag-Erling Smørgrav 5985e60d5a Solaris needs <limits.h> for NGROUPS_MAX. Don't bother making this
conditional as it's a standard header.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@267 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-07-14 15:31:38 +00:00
Dag-Erling Smørgrav 21f58dc32e Use read(2) on fileno(stdin) rather than fgets(3). This make timeout
handling considerably simpler, eliminating the need for setjmp(3) and
evil global variables.

Portions submitted by:	Dmitry V. Levin <ldv@altlinux.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@264 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-07-14 14:17:47 +00:00
Dag-Erling Smørgrav 922d9cb144 Avoid side effects in macro arguments (don't I ever learn?); also
address some related style issues.

Submitted by:	Dmitry V. Levin <ldv@altlinux.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@262 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-18 11:41:27 +00:00
Dag-Erling Smørgrav 108a953440 Staticize the default prompts.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@261 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-18 11:41:15 +00:00
Dag-Erling Smørgrav ba03913cf0 Checking the return value from pam_get_item(3) isn't enough, we also
have to check that the item isn't NULL.

Submitted by:	marcus


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@258 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-18 11:14:58 +00:00
Dag-Erling Smørgrav 5de0bf6bae Autoconfuse.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@251 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-09 01:29:37 +00:00
Dag-Erling Smørgrav 1c16675283 Paranoia: clear buffers before returning.
Submitted by:	Dmitry V. Levin <ldv@altlinux.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@250 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-09 00:47:28 +00:00
Dag-Erling Smørgrav c25cf2c668 Remove debugging output.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@248 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-02 17:03:15 +00:00
Dag-Erling Smørgrav 049385996b Give up trying to keep track of what has changed and what hasn't;
just slap a 2003 copyright on everything.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@245 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-01 14:34:11 +00:00
Dag-Erling Smørgrav 044448812b Incorporate patches from Dmitry V. Levin which improve the policy
loader, reducing the number of times each file is read.  Also fix
a few minor nits (such as making facility names and control flags
case insensitive like they are in Solaris).


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@243 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-01 14:23:25 +00:00
Dag-Erling Smørgrav 3326a91846 Cross-reference openpam_{get,set}_option(3).
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@242 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-01 14:05:15 +00:00
Dag-Erling Smørgrav 6c68711fe1 Continue improving the new configuration parser, particularly error
reporting: error messages relating to policy files now include line
numbers, and the parser will warn about invalid facility names.

Also fix an off-by-one bug in the option handling code.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@241 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-26 15:31:28 +00:00
Dag-Erling Smørgrav 0fe6f41f7c Overhaul the configuration parser. This adds support for continuation
lines and policy inclusion.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@240 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-25 18:34:31 +00:00
Dag-Erling Smørgrav 49189d9bbc Use RTLD_NOW where available, and define it to RTLD_LAZY otherwise.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@238 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-25 13:41:46 +00:00
Dag-Erling Smørgrav 592df31db1 Remove trailing semicolons from macros.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@236 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-25 12:53:36 +00:00
Dag-Erling Smørgrav 84ba876926 No need to explicitly clear pointers now that we use FREE().
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@235 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-25 12:52:31 +00:00
Dag-Erling Smørgrav df0aac6712 Return code paranoia: compare against 0 instead of -1.
Suggested by:	Dmitry V. Levin <ldv@altlinux.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@234 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-24 19:52:28 +00:00
Dag-Erling Smørgrav 7f62c5701c Two more cases of asprintf(3) replacing malloc(3) + sprintf(3).
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@233 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-24 19:47:00 +00:00
Dag-Erling Smørgrav 570d0c7751 With one single exception (where the pointer is obviously being
immediately overwritten), replace all use of free(3) with a macro
that clears the pointer after freeing the memory it pointed to.

Suggested by:	Dmitry V. Levin <ldv@altlinux.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@232 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-24 19:44:29 +00:00
Dag-Erling Smørgrav 4ec4c17dcd Reorganize. Document. Replace malloc() + sprintf() with asprintf().
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@229 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-24 19:32:38 +00:00
Dag-Erling Smørgrav 151085d688 NOLIST doesn't actually do anything, and hasn't for quite a while.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@227 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-24 18:53:26 +00:00
Dag-Erling Smørgrav 3eeb089306 Allow libpam to build on Linux.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@226 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-24 18:51:33 +00:00
Dag-Erling Smørgrav 64d0536448 Add #include <grp.h> which I missed due to namespace pollution.
Submitted by:	Dmitry V. Levin <ldv@altlinux.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@224 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-24 18:32:33 +00:00
Dag-Erling Smørgrav f013f77bff Correct old paste-o.
Submitted by:	Dmitry V. Levin <ldv@altlinux.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@222 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-23 23:47:31 +00:00
Dag-Erling Smørgrav a59c768d3e Update copyright dates for files that have changed this year. Also
change the copyright date on generated man pages from 2002 to 2001-2003
since work on this part of OpenPAM started in late 2001.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@221 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-13 14:54:04 +00:00
Dag-Erling Smørgrav 98f9303b57 Use RTLD_LAZY rather than RTLD_NOW (which apparently isn't supported
on all platforms, notably OpenBSD).

Submitted by:	Mike Petullo <mike@flyn.org>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@216 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-13 14:42:04 +00:00
Dag-Erling Smørgrav 5ad9bf2e77 Propagate version numbers and installation directories throughout
the tree using Makefile.inc.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@214 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-13 14:37:12 +00:00
Dag-Erling Smørgrav 309a306cfd Constify the return value from pam_getenv(3). This violates XSSO,
but I consider that a bug in the spec.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@211 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-01 23:10:49 +00:00
Dag-Erling Smørgrav ef2e6d8690 If compiled with -DDEBUG, enable debugging right before calling a
module which has the "debug" option, and disable it upon return.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@210 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-01 18:20:03 +00:00
Dag-Erling Smørgrav 8dcae81fe3 Add a global variable controlling the output of debugging messages.
This allows modules etc. to emit PAM_LOG_DEBUG messages independently
of whether libpam was compiled with -DDEBUG.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@209 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-01 18:18:06 +00:00
Dag-Erling Smørgrav a57c4713cf Avoid dereferencing an unitialized dl handle. Also, add a cast to
avoid a warning about assigning void * to a function pointer.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@208 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-01 18:13:09 +00:00
Dag-Erling Smørgrav 01c7951719 Variable initialization issues.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@206 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-01 17:57:17 +00:00
Dag-Erling Smørgrav c85f7eef5b Avoid a NULL pointer dereference if PAM_CONV is non-NULL but its
conv member is NULL.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@205 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-02-16 12:09:51 +00:00