OpenPAM/OpenPAM
OpenPAM/OpenPAM
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
829 commits 3 branches 10 tags 1.9 MiB
Commit graph

829 commits

This branch
This branch
All branches
Author SHA1 Message Date
Dag-Erling Smørgrav
17c3fff539 For testing purposes, add a pam_return module which can be configured to 
return any value, either by name (e.g. PAM_AUTH_ERR) or by number, even
if that number is out of range.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@873 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-12-01 19:38:01 +00:00
Dag-Erling Smørgrav
f78c2be225 Add missing third clause. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@872 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-12-01 19:25:07 +00:00
Dag-Erling Smørgrav
b3cd4386fa In t_fopen(), resolve the full path to the file before opening it. 
In t_fprintf(), immediately flush the file after writing to it.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@871 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-12-01 19:21:50 +00:00
Dag-Erling Smørgrav
d30df17f67 Increase the TOTP window to ±2 timesteps. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@870 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-10-23 10:22:35 +00:00
Dag-Erling Smørgrav
b149f4beed Fix uninitialized variable warning. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@869 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-10-23 10:19:21 +00:00
Dag-Erling Smørgrav
4a9cae719e Let the optional argument to the calc command be the total number of codes 
to print, not the number of codes in addition to the current code.
Add a -n option which causes the calc command to print the counter or
timestamp in addition to the code.
Document the fact that the calc command does not work correctly for TOTP
keys with count > 1.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@868 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-10-23 09:41:16 +00:00
Dag-Erling Smørgrav
75781c2e7c Don't forget to distribute t_pam_conv.h 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@867 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-10-23 09:10:04 +00:00
Dag-Erling Smørgrav
37b1f12e58 Deconstify across the board to dodge -Wcast-qual until we convert to the far 
superior cryb.to test framework.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@866 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-07-31 00:03:02 +00:00
Dag-Erling Smørgrav
4ee61ea341 intptr_t requires <stdint.h> 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@865 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-07-31 00:02:09 +00:00
Dag-Erling Smørgrav
a1e8de164e ignore generated file 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@864 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-07-31 00:01:51 +00:00
Dag-Erling Smørgrav
38c6ca93b2 Start writing tests for openpam_dispatch(). The first is a regression test 
for the bug fixed in r802.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@863 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-07-30 23:44:31 +00:00
Dag-Erling Smørgrav
d84d7367fe Add a feature flag to control whether to fall back to the "other" policy 
for chains that are still empty after the requested policy was loaded.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@862 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-07-30 23:42:38 +00:00
Dag-Erling Smørgrav
653950434c Fully fix the input overflow bug and add a test case for it. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@861 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-03-19 00:42:58 +00:00
Dag-Erling Smørgrav
bf92462945 Include oath.man in the distribution tarball. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@860 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-03-19 00:21:23 +00:00
Dag-Erling Smørgrav
34ef29ccf8 ignore generated file 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@859 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-03-19 00:16:42 +00:00
Dag-Erling Smørgrav
737e1bef50 Increment by three, not one, after successfully decoding a character. 
Add a boundary check.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@858 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-03-19 00:07:19 +00:00
Dag-Erling Smørgrav
a1f83b0b30 Add unit tests for RFC 3986 percent encoding / decoding. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@857 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-03-19 00:06:32 +00:00
Dag-Erling Smørgrav
ce014fab92 Silence all remaining qual-cast warnings except in the test suite. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@854 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-01-27 22:13:03 +00:00
Dag-Erling Smørgrav
563ac2d4bb Remove the pamgdb script, since "libtool exec gdb" does the same job better. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@853 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-01-15 17:20:49 +00:00
Dag-Erling Smørgrav
8a2e3ce9b6 BullseyeCoverage needs to know exactly which compiler we're using. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@852 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2015-01-15 17:18:03 +00:00
Dag-Erling Smørgrav
00fb76245a Silence an uninitialized variable warning from gcc, which does not realize 
that the resynchronization loop will always run at least once.
Adjust the loop condition, which unintentionally ignored errors.
Remove a debugging message.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@851 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-12-15 17:11:36 +00:00
Dag-Erling Smørgrav
1cffa76b4f Track liboath: 
- Use UINT_MAX to indicate an invalid response.
  - The meaning of the window parameter has changed slightly.
The calc command now accepts a count of codes to generate.
The resync command now fails if the key is not resynchronizable.
Clean up the usage message.
Document exit codes.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@850 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-12-15 17:00:59 +00:00
Dag-Erling Smørgrav
cec8549503 Change the meaning of the window parameter to always indicate the number 
of codes to check *in addition* to the current code.  Note that for TOTP,
the window goes in both directions; a window of 1 means to check the
current code plus the previous and next.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@849 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-12-15 16:42:31 +00:00
Dag-Erling Smørgrav
e959d8c160 Consistently use UINT_MAX, not -1, to indicate an invalid response. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@848 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-12-15 16:12:29 +00:00
Dag-Erling Smørgrav
2f686b73cb Require the user to specify the OATH mode (HOTP or TOTP) when generating 
a new key.

Allow resynchronizing with three keys instead of two, increasing the
resynchronization window from 100 keys to 1000 keys.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@847 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-12-11 14:06:59 +00:00
Dag-Erling Smørgrav
c7a5aa489f Add an oath_mode(3) function which translates from mode names to numbers. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@846 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-12-11 13:58:15 +00:00
Dag-Erling Smørgrav
e84c236ee9 Recognize enums and unions as well as structs. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@845 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-12-11 13:56:51 +00:00
Dag-Erling Smørgrav
8988b9122e The read-only option that was implemented in r841 was inaccessible 
because the getopt(3) spec had not been updated to include it.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@844 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-11-25 14:01:58 +00:00
Dag-Erling Smørgrav
da2c1e7120 Fix a few cases where we incorrectly (and needlessly) cast away const 
qualifiers.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@843 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-11-25 10:35:19 +00:00
Dag-Erling Smørgrav
753721df82 Implement HOTP resynchronization: the user provides two consecutive codes 
from their token.  If the first code is found within the synchronization
window (currently hardcoded to 99) and the second is the next code in the
sequence, the counter is reset to one past the second code.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@842 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-11-12 17:30:38 +00:00
Dag-Erling Smørgrav
d130c0ec09 Turn writeback mode on by default in oathkey(1). 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@841 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-11-12 16:21:15 +00:00
Dag-Erling Smørgrav
fc5eeb8fd9 Trust configure to provide the correct source directory. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@840 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-11-07 16:44:26 +00:00
Dag-Erling Smørgrav
f3fda3d07a Style nits 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@839 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-11-07 16:37:56 +00:00
Dag-Erling Smørgrav
4b2bc748fd Make sure we package symlinks as well as files, but don't package .la files. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@838 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-11-02 13:47:08 +00:00
Dag-Erling Smørgrav
273bae0b16 Oops - the line count is incremented by the line continuation, not by 
the word that precedes it.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@837 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-28 17:50:17 +00:00
Dag-Erling Smørgrav
16ae1d5b87 Further improve the line continuation tests. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@836 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-28 17:47:55 +00:00
Dag-Erling Smørgrav
1e3740645e Add a test case for line continuation within whitespace, similar to 
the corresponding test in t_openpam_readword.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@835 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-28 13:48:00 +00:00
Dag-Erling Smørgrav
ac54af0d69 Add configure options to build as much as possible using the system 
libpam and / or liboath.  Doing so disables building the corresponding
library and its documentation, but still builts the corresponding tools
and modules and runs the unit tests.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@834 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-28 10:25:58 +00:00
Dag-Erling Smørgrav
385dfb33cb Use $() instead of @@ in Makefiles. 
Don't build OATH man pages if --without-oath.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@833 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-28 09:03:41 +00:00
Dag-Erling Smørgrav
37baf24e77 Change manifest syntax from YAML to UCL to match recent versions of pkg. 
Also, move the description out of the script.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@832 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-24 11:14:51 +00:00
Dag-Erling Smørgrav
7ce556ed8d Remove obsolete text. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@831 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-24 10:58:21 +00:00
Dag-Erling Smørgrav
e6dc9378f7 staticize t_plan 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@830 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-24 08:49:47 +00:00
Dag-Erling Smørgrav
e956efb61f Better tests for line continuation. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@828 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-23 08:25:08 +00:00
Dag-Erling Smørgrav
9c55e81bbb Add a calc command that prints the current code. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@827 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-22 10:03:14 +00:00
Dag-Erling Smørgrav
e5b05552fc Remove unused variable. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@824 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-18 22:35:35 +00:00
Dag-Erling Smørgrav
ce08052f96 Compare the return value from mmap() to MAP_FAILED, not NULL. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@823 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-16 13:44:34 +00:00
Dag-Erling Smørgrav
2c148271ae Avoid double-quoting function-like macros. 
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@821 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-09 14:45:32 +00:00
Dag-Erling Smørgrav
623d9e7b2f Small tweak to avoid marking up initialisms and acronyms like GCC, API 
and PAM as code.  As a side effect, this simplifies the code for CVEs.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@820 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-09 14:34:03 +00:00
Dag-Erling Smørgrav
561cd87dbe Refactor. The only major change is that CVE numbers now link to the 
corresponding NVD database entry.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@819 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-09 14:28:41 +00:00
Dag-Erling Smørgrav
8ad7aa9039 - Set the sameuser flag when a non-root user manipulates their own key. 
- Rename the uri command to geturi (but retain backward compatibility).
- Add a getkey command that prints the key in hexadecimal.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@818 185d5e19-27fe-0310-9dcf-9bff6b9f3609
 2014-10-08 11:02:44 +00:00