Commit Graph

36 Commits

Author SHA1 Message Date
Dag-Erling Smørgrav 9bdf428c5a Fix an off-by-one bug in pam_getenv() which was inadvertantly
introduced when pam_getenv() was (needlessly) rewritten as part of
r913.  Rewrite pam_getenv() again (but correctly, this time) to reduce
the number of times we iterate over the same string.  Add a few unit
tests for pam_{get,put,set}env(), including one which would have
caught the bug.

Credit goes to Tim Creech <tcreech@tcreech.com> for discovering and
reporting the bug.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@943 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2019-02-20 13:23:51 +00:00
Dag-Erling Smørgrav 3699596d18 Correctly compare the return value from pam_get_item() to PAM_SUCCESS
instead of assuming (incorrectly) that it returns non-zero on success.
Bump dates as needed.

Reported by:	Patrick Bihan-Faou <patrick-fbsd@mindstep.com>


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@902 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2017-01-17 14:57:09 +00:00
Dag-Erling Smørgrav ce014fab92 Silence all remaining qual-cast warnings except in the test suite.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@854 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2015-01-27 22:13:03 +00:00
Dag-Erling Smørgrav b94f9e7ce7 Gavin helped out with CVE-2014-3879
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@813 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2014-09-12 07:46:23 +00:00
Dag-Erling Smørgrav 547794d58e Remove keywords from pure text files.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@804 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2014-09-09 09:11:31 +00:00
Dag-Erling Smørgrav 5fadc4abb8 Credit Larry Baird for the is_upper() bug and sort the list.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@762 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2014-02-26 16:23:41 +00:00
Dag-Erling Smørgrav df95e0530d Credit Baptiste Daroussin for his various contributions, including but not
limited to r749.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@750 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2014-01-13 21:27:03 +00:00
Dag-Erling Smørgrav a37ffba3b8 Old patch: credit Ankita Pal, who uncovered a couple of issues while
porting OpenPAM to QNX.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@625 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2013-02-25 21:12:10 +00:00
Dag-Erling Smørgrav 2546d3cf58 WIP: OATH module
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@623 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2013-02-25 07:24:51 +00:00
Dag-Erling Smørgrav f0d658d97d Jason tipped me off about a memory leak in the previous iteration of
openpam_parse_chain().


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@587 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2012-04-08 11:12:10 +00:00
Dag-Erling Smørgrav d9ae0b5836 Consistently spell email addresses in lowercase.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@586 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2012-04-08 11:11:28 +00:00
Dag-Erling Smørgrav 96357f3c52 Add an openpam_straddch() function that appends a character to a
string, reallocating the string if necessary.

Add an openpam_readword() function that reads a single word from a
file according to the usual shell quoting rules.

Add an openpam_readlinev() function that uses openpam_readword() to
read an entire line and return a list of the words it contained.

Rewrite openpam_parse_chain() using openpam_readlinev(), which greatly
simplifies the code and ensures correct parsing of module option.

Thanks to Maëlle Lesage for pointing out the issue and writing an
early version of what became the main loop in openpam_readword().


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@547 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2012-04-01 15:01:21 +00:00
Dag-Erling Smørgrav 0a4f5e9af7 Credit Don Lewis and Gleb Smirnoff for their assistance with tracking
down the recent openpam_configure() and openpam_dynamic() issues.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@526 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2012-01-11 00:47:45 +00:00
Dag-Erling Smørgrav 8372b71ce1 Add Matthias Drochner - I wish I'd remembered to do so before I rolled
Lycopsida.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@508 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2011-12-18 17:07:53 +00:00
Dag-Erling Smørgrav 2b025676c7 Document increased input validation, and credit Sebastian Krahmer for
bringing the issue to my attention.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@498 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2011-11-21 16:27:04 +00:00
Dag-Erling Smørgrav c8b7ea4e00 Alphabetical order *is* a particular order. At least if the list is
actually alphabetized.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@457 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2011-10-29 19:36:47 +00:00
Dag-Erling Smørgrav 49380d6d5e Credit Nick Hibma for suggesting and testing openpam_subst(3).
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@456 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2011-10-29 18:34:04 +00:00
Dag-Erling Smørgrav bbf803304d Credit Jörg for both past and recent assistance.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@434 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2010-03-10 11:38:03 +00:00
Dag-Erling Smørgrav e4bbcb1549 Correct email address.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@424 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2009-10-29 17:10:22 +00:00
Dag-Erling Smørgrav e9776bfa73 Convert everything to UTF-8.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@422 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2009-10-18 22:19:57 +00:00
Dag-Erling Smørgrav e484c931ae Constify.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@400 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2007-10-24 15:04:23 +00:00
Dag-Erling Smørgrav b091d056d7 Add Daniel Richard G. <skunk@iskunk.org> to the lineup.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@392 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2006-07-09 04:39:20 +00:00
Dag-Erling Smørgrav b307f0a81a Add "Wojciech A. Koszek" <wkoszek@freebsd.org>, who submitted r383.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@384 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2006-03-19 19:55:54 +00:00
Dag-Erling Smørgrav ce5921ba4c Convert $P4$ tags to $Id$.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@320 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2006-02-16 20:33:19 +00:00
Dag-Erling Smørgrav ee668335b1 Add Hubert Feyrer, also of NetBSD.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@307 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-06-09 19:10:01 +00:00
Dag-Erling Smørgrav f95eb3c6b8 Add Christos Zoulas and Emmanuel Dreyfus from NetBSD for their
contributions.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@302 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2005-02-01 12:02:37 +00:00
Dag-Erling Smørgrav 0e41195790 Correct the description of the conversation function's second argument,
and credit yar@ for spotting the mistake.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@273 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-07-21 21:58:11 +00:00
Dag-Erling Smørgrav f8982aa271 Joe Marcus Clarke is a FreeBSD committer, so list his freebsd.org
address.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@259 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-06-18 11:16:42 +00:00
Dag-Erling Smørgrav 100e6e3f0e Add Dmitry Levin (patches and fruitful conversation)
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@223 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-23 23:48:51 +00:00
Dag-Erling Smørgrav 9faa960d34 Credit Mike Petullo <mike@flyn.org> for his OpenBSD patches.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@217 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-05-13 14:42:26 +00:00
Dag-Erling Smørgrav bd2bbf2542 Credit Juli Mallett for her many contributions.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@196 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-01-06 10:03:35 +00:00
Dag-Erling Smørgrav 1a5f406a0b Credit Mikko Työläjärvi for his patch (see change 23072)
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@190 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2003-01-03 03:21:32 +00:00
Dag-Erling Smørgrav c015dbc7fc Credit eric@ for his assistance with MacOS.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@179 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2002-12-04 16:16:32 +00:00
Dag-Erling Smørgrav 0bcb04e0fd List Darren J. Moffat and Gary Winiger, both of Sun Microsystems.
Reformat a little.


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@162 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2002-06-30 22:51:46 +00:00
Dag-Erling Smørgrav ed3d5a8522 DBA update and minor whitespace fixes.
git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@157 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2002-06-07 18:22:57 +00:00
Dag-Erling Smørgrav 330a2ae4a4 Release documentation for OpenPAM Cinchona.
Sponsored by:	DARPA, NAI Labs


git-svn-id: svn+ssh://svn.openpam.org/svn/openpam/trunk@108 185d5e19-27fe-0310-9dcf-9bff6b9f3609
2002-04-08 14:19:12 +00:00