From eaf61585ea583bc75419f0af946b8e8a5f7c4dbc Mon Sep 17 00:00:00 2001 From: Patricia Aas Date: Mon, 2 Aug 2021 16:43:18 +0200 Subject: [PATCH] Fix Clang-Tidy warnings --- .clang-tidy | 2 +- lib/Board.cpp | 4 ++-- lib/Canvas.cpp | 1 - lib/include/Position.hpp | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index dfe8dd1..564c63e 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1 +1 @@ -Checks: 'modernize-*,-modernize-use-nodiscard,-modernize-use-trailing-return-type,cppcoreguidelines-*,bugprone-*,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-avoid-magic-numbers' +Checks: 'modernize-*,-modernize-use-nodiscard,-modernize-use-trailing-return-type,cppcoreguidelines-*,bugprone-*,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-pro-bounds-*,-readability-convert-member-functions-to-static' diff --git a/lib/Board.cpp b/lib/Board.cpp index 0dff967..db04da9 100644 --- a/lib/Board.cpp +++ b/lib/Board.cpp @@ -8,8 +8,8 @@ const std::size_t COLUMNS = 28; enum class Cell { wall = 0, pellet = 1, - nothing = 2, - // missing 3 + // nothing = 2, + // missing 3, power_pellet = 4, pen = 5, left_portal = 6, diff --git a/lib/Canvas.cpp b/lib/Canvas.cpp index c51a522..431c371 100644 --- a/lib/Canvas.cpp +++ b/lib/Canvas.cpp @@ -1,5 +1,4 @@ #include "Canvas.hpp" -#include "Game.hpp" #include "Scaling.hpp" #include #include diff --git a/lib/include/Position.hpp b/lib/include/Position.hpp index e5887fe..c77bfc8 100644 --- a/lib/include/Position.hpp +++ b/lib/include/Position.hpp @@ -6,8 +6,8 @@ namespace pacman { struct Position { - double x; - double y; + double x = 0; + double y = 0; }; struct GridPosition {